Skip to content

wangteng-Aug-week4 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jiakechongg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wangteng-Aug-week4 #113

jiakechongg wants to merge 1 commit into from

Conversation

@jiakechongg
Copy link
Contributor

@jiakechongg jiakechongg commented Sep 10, 2019

No description provided.

iammapping
iammapping requested changes Sep 17, 2019
View reviewed changes
Copy link
Owner

@iammapping iammapping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现得比较混乱，思路还需要再理清楚一些，多考虑怎么做可以效率更高，而不仅是得出正确结果

2019/Aug/Week4/reactive-variables.js
variablesObj[key] = val;

Object.keys(result).forEach(k => {
if(typeof result[k] === 'object') {
Copy link
Owner

@iammapping iammapping Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixme：这里的处理逻辑很不严谨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iammapping iammapping iammapping requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiakechongg @iammapping